ACMS-3577: DAM integration with starterkit (low code) doesn't work as expected. #1750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajeshreeputra
requested changes
Feb 23, 2024
apathak18
approved these changes
Feb 23, 2024
chandan-singh7929
approved these changes
Feb 23, 2024
vishalkhode1
approved these changes
Feb 23, 2024
@vishalkhode1 i think we cannot write existing test in this case as when we do DAM authentication it takes to an external site and we cannot write test for an external site. |
deepakmishra2
force-pushed
the
ACMS-3577
branch
from
fce307a to
7bf949f
Compare
deepakmishra2
force-pushed
the
ACMS-3577
branch
from
7bf949f to
fb511a6
Compare
| @@ -169,8 +169,7 @@ json_values: | | |||
| ] | |||
| }, | |||
| "attributes": { | |||
| "alt": "[media:image:alt]", | |||
| "title": "[media:image:title]" | |||
| "alt": "[media:acquia_dam_alt_text:value]" | |||
There was a problem hiding this comment.
@deepakmishra2 - This will only be generated if there is a mapping for alt text field, otherwise it will be blank because default DAM mapping doesn't have alt text field mapping out of the box.
Hence, I would suggest to use field condition then display the fallback as file name as alt value.
cc @vishalkhode1
rajeshreeputra
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… expected.
Motivation
Fixes #ACMS-3577
Proposed changes
updated attributes for media DAM
Testing steps
follow from ticket